D122: phabricator: add --amend option to phabsend

2017-08-14 Thread quark (Jun Wu)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGfa3aa6c98bb7: phabricator: add --amend option to phabsend (authored by quark). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D122?vs=838&id=873 REVISION DETAIL

D122: phabricator: add --amend option to phabsend

2017-08-12 Thread quark (Jun Wu)
quark updated this revision to Diff 838. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D122?vs=789&id=838 REVISION DETAIL https://phab.mercurial-scm.org/D122 AFFECTED FILES contrib/phabricator.py CHANGE DETAILS diff --git a/contrib/phabricator.py b/

D122: phabricator: add --amend option to phabsend

2017-08-11 Thread quark (Jun Wu)
quark updated this revision to Diff 789. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D122?vs=568&id=789 REVISION DETAIL https://phab.mercurial-scm.org/D122 AFFECTED FILES contrib/phabricator.py CHANGE DETAILS diff --git a/contrib/phabricator.py b/

D122: phabricator: add --amend option to phabsend

2017-08-04 Thread quark (Jun Wu)
quark updated this revision to Diff 568. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D122?vs=553&id=568 REVISION DETAIL https://phab.mercurial-scm.org/D122 AFFECTED FILES contrib/phabricator.py CHANGE DETAILS diff --git a/contrib/phabricator.py b/

D122: phabricator: add --amend option to phabsend

2017-08-04 Thread quark (Jun Wu)
quark updated this revision to Diff 553. quark edited the test plan for this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D122?vs=485&id=553 REVISION DETAIL https://phab.mercurial-scm.org/D122 AFFECTED FILES contrib/phabricator.py CHANGE D

D122: phabricator: add --amend option to phabsend

2017-08-01 Thread quark (Jun Wu)
quark updated this revision to Diff 485. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D122?vs=233&id=485 REVISION DETAIL https://phab.mercurial-scm.org/D122 AFFECTED FILES contrib/phabricator.py CHANGE DETAILS diff --git a/contrib/phabricator.py b/

Re: D122: phabricator: add --amend option to phabsend

2017-07-18 Thread quark (Jun Wu)
quark added inline comments. INLINE COMMENTS > mitrandir wrote in phabricator.py:413 > I think it would be better to use differential.getcommitmessage for this. For > example "reviewed by" field is a really nice thing to have in the commit > message. I was trying to make it behave closer to `h

Re: D122: phabricator: add --amend option to phabsend

2017-07-18 Thread mitrandir (Mateusz Jakub Kwapich)
mitrandir accepted this revision. mitrandir added inline comments. INLINE COMMENTS > phabricator.py:413 > +drev = [d for d in drevs if int(d[r'id']) == drevid][0] > +newdesc = getdescfromdrev(drev) > +# Make sure commit message contain "Differential

Re: D122: phabricator: add --amend option to phabsend

2017-07-17 Thread quark (Jun Wu)
quark created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Previously `hg phabsend` was imitating `hg email` and won't mutate changesets. That works fine with reviewer-push workflow, reviewers run `phabread`, `import`.