D1285: localrepo: add a new attribute _visibilityexceptions and related API

2017-11-20 Thread quark (Jun Wu)
quark added a comment. I mean, having an empty shim in unfiltered repo: def addvisibilityexceptions(...): pass def getvisibilityexceptions(...): return () I think the state of "visibilityexception" should really be bounded into whoever controls "filteredrev

D1285: localrepo: add a new attribute _visibilityexceptions and related API

2017-11-20 Thread pulkit (Pulkit Goyal)
pulkit added a comment. In https://phab.mercurial-scm.org/D1285#22442, @quark wrote: > I think `localrepo` object is usually for unfiltered access therefore the visibility exception API looks strange to me. > > Maybe move them to the `repoview` layer? The functions to compute

D1285: localrepo: add a new attribute _visibilityexceptions and related API

2017-11-09 Thread quark (Jun Wu)
quark added a comment. I think `localrepo` object is usually for unfiltered access therefore the visibility exception API looks strange to me. INLINE COMMENTS > localrepo.py:516 > +def addvisibilityexceptions(self, exceptions): > +""" adds hidden revs which should be visible to s

D1285: localrepo: add a new attribute _visibilityexceptions and related API

2017-11-02 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Currently we don't have a defined way in core to make some hidden revisions visible in filtered repo. Extensions to achieve the purpose of unhiding some hidden co