This revision was automatically updated to reflect the committed changes.
Closed by commit rHGf56a30b844aa: rebase: use fm.formatlist() and
fm.formatdict() to support user template (authored by pulkit, committed by ).
CHANGED PRIOR TO COMMIT
yuja added a comment.
Queued the series, many thanks.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1293
To: pulkit, #hg-reviewers, yuja
Cc: yuja, mercurial-devel
___
Mercurial-devel mailing list
pulkit updated this revision to Diff 3725.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1293?vs=3705=3725
REVISION DETAIL
https://phab.mercurial-scm.org/D1293
AFFECTED FILES
hgext/rebase.py
tests/test-rebase-templates.t
CHANGE DETAILS
diff
yuja added a comment.
> I am not sure whether that was what you wanted.
It's getting closer, thanks. What I meant is `{key}` and `{value}` wouldn't
be good
keyword names because the they are actually an old node and a list of new
nodes
respectively.
I think a template should be
pulkit added a comment.
In https://phab.mercurial-scm.org/D1293#22323, @yuja wrote:
> Something like this:
>
> -T '{nodechanges % ": {value % ...}"}'
I have added a test. I am not sure whether that was what you wanted.
(Fun fact: I was trying various permutations of
pulkit updated this revision to Diff 3705.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1293?vs=3670=3705
REVISION DETAIL
https://phab.mercurial-scm.org/D1293
AFFECTED FILES
hgext/rebase.py
tests/test-rebase-templates.t
CHANGE DETAILS
diff
pulkit updated this revision to Diff 3670.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1293?vs=3229=3670
REVISION DETAIL
https://phab.mercurial-scm.org/D1293
AFFECTED FILES
hgext/rebase.py
tests/test-rebase-templates.t
CHANGE DETAILS
diff
pulkit added a comment.
In https://phab.mercurial-scm.org/D1293#21761, @yuja wrote:
> Can you add a test that should be fixed by this patch?
> Perhaps that will show we'll probably want to set the name of dict item
pair
> other than the default 'key'/'value'.
Sorry but I am
yuja requested changes to this revision.
yuja added a comment.
This revision now requires changes to proceed.
Can you add a test that should be fixed by this patch?
Perhaps that will show we'll probably want to set the name of dict item pair
other than the default 'key'/'value'.
INLINE
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Thanks to Yuya for suggesting this in https://phab.mercurial-scm.org/D1173.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1293
10 matches
Mail list logo