D1428: logtoprocess: connect all fds to /dev/null to avoid bad interaction with pager

2018-10-01 Thread lothiraldan (Boris Feld)
lothiraldan abandoned this revision. lothiraldan added a comment. Replaced by https://phab.mercurial-scm.org/D4816 REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1428 To: lothiraldan, #hg-reviewers, yuja Cc: yuja, mercurial-devel

D1428: logtoprocess: connect all fds to /dev/null to avoid bad interaction with pager

2017-12-15 Thread lothiraldan (Boris Feld)
lothiraldan updated this revision to Diff 4469. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1428?vs=3917=4469 REVISION DETAIL https://phab.mercurial-scm.org/D1428 AFFECTED FILES hgext/logtoprocess.py tests/test-logtoprocess.t CHANGE DETAILS

D1428: logtoprocess: connect all fds to /dev/null to avoid bad interaction with pager

2017-11-28 Thread lothiraldan (Boris Feld)
lothiraldan updated this revision to Diff 3917. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1428?vs=3589=3917 REVISION DETAIL https://phab.mercurial-scm.org/D1428 AFFECTED FILES hgext/logtoprocess.py tests/test-logtoprocess.t CHANGE DETAILS

D1428: logtoprocess: connect all fds to /dev/null to avoid bad interaction with pager

2017-11-17 Thread lothiraldan (Boris Feld)
lothiraldan updated this revision to Diff 3589. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1428?vs=3530=3589 REVISION DETAIL https://phab.mercurial-scm.org/D1428 AFFECTED FILES hgext/logtoprocess.py tests/test-logtoprocess.t CHANGE DETAILS

D1428: logtoprocess: connect all fds to /dev/null to avoid bad interaction with pager

2017-11-17 Thread lothiraldan (Boris Feld)
lothiraldan added inline comments. INLINE COMMENTS > yuja wrote in logtoprocess.py:89 > stdout and stderr should be writable. We can simply pass a file > descriptor open with O_RDWR. > > nullfd = os.open(os.devnull, os.O_RDWR) > Popen(stdin=nullfd, stdout=nullfd, stderr=nullfd) > > and

D1428: logtoprocess: connect all fds to /dev/null to avoid bad interaction with pager

2017-11-15 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We detected that pager is waiting for log-to-process script to finish, which is annoying when adding a script on commandfinish that does an HTTP push.