This revision was automatically updated to reflect the committed changes.
Closed by commit rHG02b36e860e0b: workers: implemented worker on windows
(authored by wlis, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1458?vs=3665&id=4485
REVIS
wlis added a comment.
@durin42 yes, I tested without remotefilelog (at least I believe it was not
being used at that time). I cloned a repo with --config
extensions.remotefilelog=! and then put appropriate section in .hg/hgrc
Ran updates between far revisions and verified that threads get s
durin42 added a comment.
Did you test this on a non-remotefilelog repo?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1458
To: wlis, #hg-reviewers
Cc: durin42, indygreg, mercurial-devel
___
Mercurial-devel mailing lis
wlis added a comment.
The previous issues were related to fb-hgext remotefilelog and
https://phab.mercurial-scm.org/D1513 fixes it on the side of remotefilelog.
I will still need to test this code on a repo without remotefilelog to make
sure that the normal filelog doesn't hit similar issue
wlis planned changes to this revision.
wlis added a comment.
I need to test these changes a bit more. I found a place in merge.py that has
a risk of race condition and need to figure out how to protect it.
Right now there are 2 places where we use workers. 1 in core (merge.py) and
there is
indygreg added a comment.
I haven't looked at the code in much detail.
The use of threads for the workers on Windows is obviously better performance
wise than the current world where we use a single thread in a single process.
However, we'll hit the upper limit of performance pretty quic
wlis created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This change implements thread based worker on windows.
The handling of exception from within threads will happen in separate diff.
The worker is for now used in
