phillco added inline comments.
INLINE COMMENTS
> krbullock wrote in rebase.py:393
> Rather than having this method spookily set self.wctx, why not make
> `_assignworkingcopy` _return_ the wctx (and rename it accordingly)?
Good point, I'll send a followup.
REPOSITORY
rHG Mercurial
REVISION
krbullock added inline comments.
INLINE COMMENTS
> rebase.py:393
> +def _performrebase(self, tr):
> +self._assignworkingcopy()
> +repo, ui = self.repo, self.ui
Rather than having this method spookily set self.wctx, why not make
`_assignworkingcopy` _return_ the wctx (and
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG8dba17546016: rebase: extract _assignworkingcopy (authored
by phillco, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1617?vs=4277=4286
REVISION
phillco updated this revision to Diff 4277.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1617?vs=4248=4277
REVISION DETAIL
https://phab.mercurial-scm.org/D1617
AFFECTED FILES
hgext/rebase.py
CHANGE DETAILS
diff --git a/hgext/rebase.py
phillco updated this revision to Diff 4248.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1617?vs=4243=4248
REVISION DETAIL
https://phab.mercurial-scm.org/D1617
AFFECTED FILES
hgext/rebase.py
CHANGE DETAILS
diff --git a/hgext/rebase.py
phillco created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Slightly cleaner, and makes it easier to hook this in an extension.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1617
AFFECTED
