Re: D1698: copies: group wdir-handling in one place

2017-12-15 Thread Kevin Bullock
> On Dec 15, 2017, at 10:41, martinvonz (Martin von Zweigbergk) > wrote: > > martinvonz added inline comments. > > INLINE COMMENTS > >> krbullock wrote in copies.py:206 >> Post-queue nitpick: unnecessary `else:`. > > Feel free to update Fixed in-flight, thanks. pacem in terris / мир / शान्त

D1698: copies: group wdir-handling in one place

2017-12-15 Thread martinvonz (Martin von Zweigbergk)
martinvonz added inline comments. INLINE COMMENTS > krbullock wrote in copies.py:206 > Post-queue nitpick: unnecessary `else:`. Feel free to update REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1698 To: martinvonz, #hg-reviewers, yuja Cc: krbullock, mercurial-de

D1698: copies: group wdir-handling in one place

2017-12-15 Thread krbullock (Kevin Bullock)
krbullock added inline comments. INLINE COMMENTS > copies.py:206 > +return _chain(a, b, cm, _dirstatecopies(b, match)) > +else: > +return _committedforwardcopies(a, b, match) Post-queue nitpick: unnecessary `else:`. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.

D1698: copies: group wdir-handling in one place

2017-12-15 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG143f09cfc80f: copies: group wdir-handling in one place (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1698?vs=4447&id=447

D1698: copies: group wdir-handling in one place

2017-12-15 Thread yuja (Yuya Nishihara)
yuja added a comment. Nice. Queued, thanks. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1698 To: martinvonz, #hg-reviewers, yuja Cc: mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org

D1698: copies: group wdir-handling in one place

2017-12-14 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I think this makes it both easier to follow and shorter. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1698 AFFECTED FILES mer