pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This patch adds two new namespaces which will be enabled by remotenames
extension. The namespaces are remotebookmarks and remotebranches. Adding them
as namespace
durin42 requested changes to this revision.
durin42 added a comment.
This revision now requires changes to proceed.
Easiest path is to mark this as experimental, and then we can do an iteration
in the next cycle and remove the warning label.
INLINE COMMENTS
> remotenames.py:189
> +
pulkit added inline comments.
INLINE COMMENTS
> durin42 wrote in remotenames.py:189
> Hm, I'm not sure if we want to name remote{bookmarks,branches} the same as
> local ones in log output. It may make sense to defer this until after the
> freeze, or else mark the remotenames extension as experi
pulkit added inline comments.
INLINE COMMENTS
> durin42 wrote in remotenames.py:189
> Hm, I'm not sure if we want to name remote{bookmarks,branches} the same as
> local ones in log output. It may make sense to defer this until after the
> freeze, or else mark the remotenames extension as experi
durin42 added inline comments.
INLINE COMMENTS
> pulkit wrote in remotenames.py:189
> > Hm, I'm not sure if we want to name remote{bookmarks,branches} the same as
> > local ones in log > output.
>
> Does remotebookmark, and remotebranch sounds good?
Works for me.
REPOSITORY
rHG Mercurial
R
martinvonz added inline comments.
INLINE COMMENTS
> pulkit wrote in remotenames.py:189
> > Hm, I'm not sure if we want to name remote{bookmarks,branches} the same as
> > local ones in log > output.
>
> Does remotebookmark, and remotebranch sounds good?
> Does remotebookmark, and remotebranch s
pulkit updated this revision to Diff 5147.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1758?vs=4612&id=5147
REVISION DETAIL
https://phab.mercurial-scm.org/D1758
AFFECTED FILES
hgext/remotenames.py
tests/test-logexchange.t
CHANGE DETAILS
diff --
pulkit added inline comments.
INLINE COMMENTS
> martinvonz wrote in remotenames.py:189
> > Does remotebookmark, and remotebranch sounds good?
>
> Will the log output get aligned for these longer names?
>
> Should we include a space? "remote bookmark:" looks more user-friendly
I made it `remote
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG382aefea8faf: remotenames: add new namespaces for
remotebookmarks and remotebranches (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-sc
martinvonz added inline comments.
INLINE COMMENTS
> test-logexchange.t:130-131
> + | tag: tip
> + | remote branch:$TESTTMP/server2/wat
> + | remote branch:default/wat
> + | parent: 4:aa98ab95a928
This is pretty hard to read. Should we at least add a space between the
label-
pulkit added inline comments.
INLINE COMMENTS
> martinvonz wrote in test-logexchange.t:130-131
> This is pretty hard to read. Should we at least add a space between the
> label-and-colon and the value?
I agree with you. I will send a followup for this.
REPOSITORY
rHG Mercurial
REVISION DETA
11 matches
Mail list logo
