D2013: commit: allow --no-secret to override phases.new-commit setting

2018-03-06 Thread spectral (Kyle Lippincott)
spectral added a comment. In https://phab.mercurial-scm.org/D2013#43547, @martinvonz wrote: > In https://phab.mercurial-scm.org/D2013#43542, @indygreg wrote: > > > @spectral: what's the state of this series? Do you plan to submit a follow-up? > > > I think he's waiting for me to

D2013: commit: allow --no-secret to override phases.new-commit setting

2018-03-06 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In https://phab.mercurial-scm.org/D2013#43542, @indygreg wrote: > @spectral: what's the state of this series? Do you plan to submit a follow-up? I think he's waiting for me to hopefully do it in a more generic way. I have been working on that. Turned o

D2013: commit: allow --no-secret to override phases.new-commit setting

2018-03-06 Thread indygreg (Gregory Szorc)
indygreg added a comment. @spectral: what's the state of this series? Do you plan to submit a follow-up? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2013 To: spectral, #hg-reviewers Cc: indygreg, martinvonz, mercurial-devel ___

D2013: commit: allow --no-secret to override phases.new-commit setting

2018-02-16 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In https://phab.mercurial-scm.org/D2013#34509, @martinvonz wrote: > In https://phab.mercurial-scm.org/D2013#34320, @spectral wrote: > > > In https://phab.mercurial-scm.org/D2013#33867, @martinvonz wrote: > > > > > I wonder if we should instead have a --d

D2013: commit: allow --no-secret to override phases.new-commit setting

2018-02-06 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In https://phab.mercurial-scm.org/D2013#34320, @spectral wrote: > In https://phab.mercurial-scm.org/D2013#33867, @martinvonz wrote: > > > I wonder if we should instead have a --draft option for this. Reasons: > > > > - If we ever add a fourth phase (like

D2013: commit: allow --no-secret to override phases.new-commit setting

2018-02-05 Thread spectral (Kyle Lippincott)
spectral added a comment. In https://phab.mercurial-scm.org/D2013#33867, @martinvonz wrote: > I wonder if we should instead have a --draft option for this. Reasons: > > - If we ever add a fourth phase (like Jun's proposed "archived" phase), then --no-secret doesn't clearly indicate "d

D2013: commit: allow --no-secret to override phases.new-commit setting

2018-02-05 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In https://phab.mercurial-scm.org/D2013#33867, @martinvonz wrote: > I wonder if we should instead have a --draft option for this. Reasons: > > - If we ever add a fourth phase (like Jun's proposed "archived" phase), then --no-secret doesn't clearly indicate

D2013: commit: allow --no-secret to override phases.new-commit setting

2018-02-02 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. I wonder if we should instead have a --draft option for this. Reasons: - If we ever add a fourth phase (like Jun's proposed "archived" phase), then --no-secret doesn't clearly indicate "draft", it could just as well be "archived". - Actually, we of course al

D2013: commit: allow --no-secret to override phases.new-commit setting

2018-02-02 Thread spectral (Kyle Lippincott)
spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Previously, if the user had phases.new-commit=secret, there was no way on the command line to commit as draft. This lets the user specify --no-secret to request