D2079: color: honor NO_COLOR

2018-02-15 Thread yuja (Yuya Nishihara)
yuja requested changes to this revision. yuja added a comment. This revision now requires changes to proceed. (just clarify the current state of this patch) REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2079 To: indygreg, #hg-reviewers, lothiraldan, yuja Cc:

D2079: color: honor NO_COLOR

2018-02-10 Thread quark (Jun Wu)
quark added a subscriber: durin42. quark added a comment. The goal was to allow users to override system default using environment variables. So a separate `[systemdefaults]` (proposed by @durin42) becomes unnecessary. REPOSITORY rHG Mercurial REVISION DETAIL

D2079: color: honor NO_COLOR

2018-02-10 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In https://phab.mercurial-scm.org/D2079#35154, @yuja wrote: > > I'm not sure if the precedence of settings is proper here. > > Perhaps it should be placed at the same level as `$EDITOR` (i.e. envrcitems)? I haven't bothered checking what that means

D2079: color: honor NO_COLOR

2018-02-10 Thread yuja (Yuya Nishihara)
yuja added a comment. > I'm not sure if the precedence of settings is proper here. Perhaps it should be placed at the same level as `$EDITOR` (i.e. envrcitems)? And can you update help/color and environment? REPOSITORY rHG Mercurial REVISION DETAIL

D2079: color: honor NO_COLOR

2018-02-07 Thread quark (Jun Wu)
quark added a comment. You might want to let run-tests.py drop NO_COLOR for tests. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2079 To: indygreg, #hg-reviewers, lothiraldan Cc: quark, lothiraldan, mercurial-devel

D2079: color: honor NO_COLOR

2018-02-07 Thread lothiraldan (Boris Feld)
lothiraldan accepted this revision. lothiraldan added a comment.  Hurrah for standards! REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2079 To: indygreg, #hg-reviewers, lothiraldan Cc: lothiraldan, mercurial-devel

D2079: color: honor NO_COLOR

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The http://no-color.org/ initiative is trying to get programs that emit color by default to honor a NO_COLOR environment variable to disable color. I