D2396: stack: import Evolve stack test file

lothiraldan marked 3 inline comments as done. lothiraldan added inline comments. INLINE COMMENTS > yuja wrote in revset.py:1549 > This breaks the order of `tip:0 & stack()` for example, and is moot > since > https://phab.mercurial-scm.org/rHG68fcc5503ec55bda2d6be2887f8fc3f61000c666, > which

D2396: stack: import Evolve stack test file

lothiraldan added inline comments. INLINE COMMENTS > martinvonz wrote in test-stack.t:96-108 > I think I would have preferred to see all of these in my stack rather than > just commit 6. Would you? The goal of this series is to define a clean stack definition API. We started by reusing the

D2396: stack: import Evolve stack test file

yuja added inline comments. INLINE COMMENTS > revset.py:1549 > +# Force to use the order of the stacks instead of the subset one > +return stacks & subset > + This breaks the order of `tip:0 & stack()` for example, and is moot since

D2396: stack: import Evolve stack test file

yuja added inline comments. INLINE COMMENTS > indygreg wrote in revset.py:1534 > I'm not sure if the predicate should be prefixed with an underscore to mark > it as internal. My reading of the help code is that the lack of a docstring > will hide it from the docs. > > I /think/ this is OK.

D2396: stack: import Evolve stack test file

martinvonz added inline comments. INLINE COMMENTS > test-stack.t:81 > + | > + o 3 foo draft c_d > + | What if this was @ in the hg repo and only commits 4 and 5 were my own, then I would not want it to be part of my stack. It feels like a definition of upstream would be very helpful.

D2396: stack: import Evolve stack test file

This revision was automatically updated to reflect the committed changes. Closed by commit rHG407934a97bc7: stack: import Evolve stack test file (authored by lothiraldan, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D2396?vs=6213=7125#toc REPOSITORY rHG Mercurial

D2396: stack: import Evolve stack test file

indygreg accepted this revision. indygreg added a subscriber: yuja. indygreg added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > revset.py:1534 > > +@predicate('stack([revs])', safe=True) > +def _stack(repo, subset, x): I'm not sure if the predicate

D2396: stack: import Evolve stack test file

lothiraldan updated this revision to Diff 6213. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2396?vs=6010=6213 REVISION DETAIL https://phab.mercurial-scm.org/D2396 AFFECTED FILES mercurial/revset.py tests/test-stack.t CHANGE DETAILS diff --git

D2396: stack: import Evolve stack test file

indygreg added a comment. I haven't looked at the remainder of the series, but it feels weird to basically reinvent a special case of `hg log` as a debug command. I do see there is a commit introducing a revset for `stack`. Perhaps we could move it up in the series so we don't need what

D2396: stack: import Evolve stack test file

lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Import Evolve stack test file for starting to have good coverage on stack definition. REPOSITORY rHG Mercurial REVISION DETAIL