D2668: rebase: introduce support for automatically rebasing orphan changes

This revision was automatically updated to reflect the committed changes. Closed by commit rHG92213f6745ed: rebase: introduce support for automatically rebasing orphan changes (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2668: rebase: introduce support for automatically rebasing orphan changes

durin42 marked an inline comment as done. durin42 added a comment. I'm not in love with the function name in destutil, but it's the best I've got. Open to suggestions, or we can change it in the future. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2668 To:

D2668: rebase: introduce support for automatically rebasing orphan changes

durin42 updated this revision to Diff 8390. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2668?vs=8361=8390 REVISION DETAIL https://phab.mercurial-scm.org/D2668 AFFECTED FILES hgext/rebase.py mercurial/destutil.py tests/test-rebase-obsolete.t

D2668: rebase: introduce support for automatically rebasing orphan changes

krbullock requested changes to this revision. krbullock added a comment. This revision now requires changes to proceed. Looks like a couple unresolved comments on _possibledestination, plus one nitpick. I think we can clean those things up easily and then land this though. INLINE COMMENTS >

D2668: rebase: introduce support for automatically rebasing orphan changes

durin42 updated this revision to Diff 8361. durin42 edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2668?vs=7914=8361 REVISION DETAIL https://phab.mercurial-scm.org/D2668 AFFECTED FILES hgext/rebase.py

D2668: rebase: introduce support for automatically rebasing orphan changes

quark added a subscriber: mbthomas. quark added a comment. In https://phab.mercurial-scm.org/D2668#51423, @durin42 wrote: > I like the way `--auto` (or some other name) is discoverable in `hg help rebase`. Losing that inside the long-form prose of the help text (which is the only place

D2668: rebase: introduce support for automatically rebasing orphan changes

durin42 marked an inline comment as done. durin42 added a comment. In https://phab.mercurial-scm.org/D2668#43338, @quark wrote: > My initial idea was to allow `-r 'orphan()-obsolete()' -d auto`. That can be actually done without any code change by defining `auto` as a complex revset. >

D2668: rebase: introduce support for automatically rebasing orphan changes

quark added a comment. My initial idea was to allow `-r 'orphan()-obsolete()' -d auto`. That can be actually done without any code change by defining `auto` as a complex revset. That idea derived an idea of allowing omitting arguments. rebase.autodest = ... # when -r or -s is

D2668: rebase: introduce support for automatically rebasing orphan changes

indygreg requested changes to this revision. indygreg added a comment. This revision now requires changes to proceed. I'm +1 on the feature. We should bikeshed the naming. INLINE COMMENTS > rebase.py:123 > > +def _possibledestination(repo, rev): > +"""Return all changesets that may be

D2668: rebase: introduce support for automatically rebasing orphan changes

durin42 updated this revision to Diff 6611. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2668?vs=6610=6611 REVISION DETAIL https://phab.mercurial-scm.org/D2668 AFFECTED FILES hgext/rebase.py tests/test-rebase-obsolete.t CHANGE DETAILS diff

D2668: rebase: introduce support for automatically rebasing orphan changes

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY _destautorebase(SRC) is based on the _destrestack(SRC) revset from fbamend. The supporting _possibledestination function is extracted from evolve, with minor