D2723: httppeer: remove _requestbuilder attribute

2018-03-15 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In https://phab.mercurial-scm.org/D2723#46187, @pulkit wrote: > Looks like this was added so that extensions can replace using urllib2.Request. https://www.mercurial-scm.org/repo/hg/rev/00ecc894138d Thanks for looking that up. We still depend on it, so

D2723: httppeer: remove _requestbuilder attribute

2018-03-15 Thread pulkit (Pulkit Goyal)
pulkit added a comment. Looks like this was added so that extensions can replace using urllib2.Request. https://www.mercurial-scm.org/repo/hg/rev/00ecc894138d REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2723 To: indygreg, #hg-reviewers Cc: pulkit, mercurial-

D2723: httppeer: remove _requestbuilder attribute

2018-03-12 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 6973. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2723?vs=6718&id=6973 REVISION DETAIL https://phab.mercurial-scm.org/D2723 AFFECTED FILES mercurial/httppeer.py CHANGE DETAILS diff --git a/mercurial/httppeer

D2723: httppeer: remove _requestbuilder attribute

2018-03-07 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This was a glorified alias to a function in another module. I have no clue why it existed. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-s