yuja added a comment.
Queued new version, thanks.
FWIW, `phabup` complains that "You can not accept this revision because it
has already been closed. Only open revisions can be accepted."
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2729
To: spectral, #
spectral updated this revision to Diff 7191.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2729?vs=7190&id=7191
REVISION DETAIL
https://phab.mercurial-scm.org/D2729
AFFECTED FILES
hgext/largefiles/overrides.py
mercurial/cmdutil.py
tests/test-rena
spectral added a reviewer: indygreg.
spectral added a comment.
In https://phab.mercurial-scm.org/D2729#46372, @martinvonz wrote:
> Greg has some concerns about this patch and it sounds like you will make
some changes. The patch was queued by Augie, but I'm dropping it for now, so we
don'
spectral updated this revision to Diff 7190.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2729?vs=6967&id=7190
REVISION DETAIL
https://phab.mercurial-scm.org/D2729
AFFECTED FILES
hgext/largefiles/overrides.py
mercurial/cmdutil.py
tests/test-rena
martinvonz added a comment.
In https://phab.mercurial-scm.org/D2729#45787, @spectral wrote:
> In https://phab.mercurial-scm.org/D2729#45664, @indygreg wrote:
>
> > I'm sorry, but we cannot ship this as is.
> >
> > The reason is mtime based build systems, like GNU make.
> >
> >
spectral added a comment.
In https://phab.mercurial-scm.org/D2729#45664, @indygreg wrote:
> I'm sorry, but we cannot ship this as is.
>
> The reason is mtime based build systems, like GNU make.
>
> We can't have version control modifying files without bumping their mtime
because t
indygreg added a comment.
I'm sorry, but we cannot ship this as is.
The reason is mtime based build systems, like GNU make.
We can't have version control modifying files without bumping their mtime
because this invalidates the target freshness checks of mtime-based build
systems.
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG9e460318ca4b: copyfile: preserve stat info (mtime, etc.)
when doing copies/renames (authored by spectral, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-sc
spectral updated this revision to Diff 6965.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2729?vs=6964&id=6965
REVISION DETAIL
https://phab.mercurial-scm.org/D2729
AFFECTED FILES
hgext/largefiles/overrides.py
mercurial/cmdutil.py
tests/test-rena
durin42 requested changes to this revision.
durin42 added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> test-rename.t:681
> + >>> filename = "mtime2/f"
> + >>> sys.exit(int(not (os.stat(filename).st_mtime < 1234567999)))
Oh, probably don't do sys.exit here.
spectral marked 2 inline comments as done.
spectral added a comment.
Neat, didn't know about the inline python stuff. That's much nicer.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2729
To: spectral, #hg-reviewers, durin42
Cc: durin42, mercurial-devel
__
spectral updated this revision to Diff 6964.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2729?vs=6735&id=6964
REVISION DETAIL
https://phab.mercurial-scm.org/D2729
AFFECTED FILES
hgext/largefiles/overrides.py
mercurial/cmdutil.py
tests/test-rena
durin42 added inline comments.
INLINE COMMENTS
> test-rename.t:668
> + $ mkdir mtime
> + $ python -c 'import os; p="mtime/f"; t=1234567890; open(p, "w").close();
> os.utime(p, (t, t))'
> + $ hg ci -qAm 'add mtime dir'
You either need to do $PYTHON or do inline python, eg
>>> import os
>
spectral created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2729
AFFECTED FILES
hgext/largefiles/overrides.py
mercurial/cmdutil.py
tests/test-rename.t
CHANGE
14 matches
Mail list logo
