D2763: xdiff: remove unused flags parameter

2018-03-09 Thread quark (Jun Wu)
quark added a comment. I don't think the Python ".so"s should be consumed by non-Python "dlopen". So "version" doesn't change since Python API remains the same. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2763 To: quark, #hg-reviewers, indygreg Cc: indygreg,

D2763: xdiff: remove unused flags parameter

2018-03-09 Thread quark (Jun Wu)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG4c8ffc67bac2: xdiff: remove unused flags parameter (authored by quark, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2763?vs=6800&id=6808 REVISI

D2763: xdiff: remove unused flags parameter

2018-03-09 Thread indygreg (Gregory Szorc)
indygreg accepted this revision. indygreg added a comment. This revision is now accepted and ready to land. Strictly speaking, we might want to bump the C extension version number because of the ABI change. But I'm not sure if these functions are exported or even used by our C extension. So i

D2763: xdiff: remove unused flags parameter

2018-03-09 Thread quark (Jun Wu)
quark created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY After https://phab.mercurial-scm.org/D2683, the flags parameter in some functions is no longer needed. Thus removed. REPOSITORY rHG Mercurial REVISION DETAIL