yuja added inline comments.
INLINE COMMENTS
> util.py:2569
> +res = self.read(len(b))
> +if res is None:
> +return None
I think read() never returns None.
> wireprotoserver.py:402
> +action, meta = reactor.onframerecv(frametype, frameflags, payload)
> +
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG8c3c47362934: wireproto: implement basic frame reading and
processing (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2852?v
indygreg updated this revision to Diff 7140.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2852?vs=7048&id=7140
REVISION DETAIL
https://phab.mercurial-scm.org/D2852
AFFECTED FILES
mercurial/configitems.py
mercurial/util.py
mercurial/wireprotofram
indygreg updated this revision to Diff 7048.
indygreg edited the summary of this revision.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2852?vs=7018&id=7048
REVISION DETAIL
https://phab.mercurial-scm.org/D2852
AFFECTED FILES
mercurial/configitems.py
indygreg abandoned this revision.
indygreg added inline comments.
INLINE COMMENTS
> wireprotoframing.py:81-87
> +def readframe(fh):
> +"""Read a unified framing protocol frame from a file object.
> +
> +Returns a 3-tuple of (type, flags, payload) for the decoded frame or
> +None if no
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
We just implemented support for writing frames. Now let's implement
support for reading them.
The bulk of the new code is for a class that maintains the stat
