D2864: contrib: open a hole in the open().read() ban for open().close()

2018-03-15 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG1190449c807d: contrib: open a hole in the open().read() ban for open().close() (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org

D2864: contrib: open a hole in the open().read() ban for open().close()

2018-03-14 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It turns out open().close() is both fine and something we occasionally do to verify something can be written. The few cases in the codebase were getting missed d