This revision was automatically updated to reflect the committed changes.
Closed by commit rHG41ba336d9f1e: fix: use a portable python script instead of
sed in test (authored by hooper, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2988?vs
durin42 accepted this revision.
durin42 added a comment.
This revision is now accepted and ready to land.
Sorry, this fell through the cracks somehow. Queued.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2988
To: hooper, #hg-reviewers, durin42
Cc: durin42, mha
mharbison72 added a comment.
Any movement on this? There's a lot of test spew on Windows that this would
cut out.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2988
To: hooper, #hg-reviewers
Cc: durin42, mharbison72, mercurial-devel
__
durin42 added a comment.
In https://phab.mercurial-scm.org/D2988#48864, @mharbison72 wrote:
> I'm not sure what the state of this is (`hg phabread` failed for 3022 and
3023), but this works on Windows. I've got a separate patch to fix the printfs
(which doesn't help the {rootpath} issue
hooper added a comment.
In https://phab.mercurial-scm.org/D2988#48864, @mharbison72 wrote:
> I'm not sure what the state of this is (`hg phabread` failed for 3022 and
3023), but this works on Windows. I've got a separate patch to fix the printfs
(which doesn't help the {rootpath} issue
mharbison72 added a subscriber: durin42.
mharbison72 added a comment.
I'm not sure what the state of this is (`hg phabread` failed for 3022 and
3023), but this works on Windows. I've got a separate patch to fix the printfs
(which doesn't help the {rootpath} issue I mentioned).
In https:
hooper updated this revision to Diff 7522.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2988?vs=7451&id=7522
REVISION DETAIL
https://phab.mercurial-scm.org/D2988
AFFECTED FILES
tests/test-fix-topology.t
tests/test-fix.t
CHANGE DETAILS
diff --git
hooper added a comment.
> - subprocess: /usr/bin/python $TESTTMP/uppercase.py 1-1 3-3 + subprocess:
c:/Python27/python.exe $TESTTMP/uppercase.py 1-1 3-3
I had wondered if there's a reason we don't substitute $PYTHON like we do
$TESTTMP? The glob makes the test a little weaker.
> I'
mharbison72 added a comment.
sys.std* need the procutil.setbinary() treatment, and globbing applied to the
delta below to keep Windows happy. Also, test-fix-topology.t probably needs
the same fix.
--- c:/Users/Matt/projects/hg/tests/test-fix.t
+++ c:/Users/Matt/projects/hg/tests/t
hooper created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2988
AFFECTED FILES
tests/test-fix.t
CHANGE DETAILS
diff --git a/tests/test-fix.t b/tests/test-fix.t
-
10 matches
Mail list logo