D3125: py3: convert user value to bytes using pycompat.fsencode()

2018-04-05 Thread pulkit (Pulkit Goyal)
pulkit added a comment. In https://phab.mercurial-scm.org/D3125#50284, @yuja wrote: > Unicode issue is handled by posix.py. The problem is `mockgetuser()` > returns a unicode string. Thanks, I overlooked that and was unable to find what can cause trouble so just added an extra

D3125: py3: convert user value to bytes using pycompat.fsencode()

2018-04-05 Thread yuja (Yuya Nishihara)
yuja requested changes to this revision. yuja added a comment. This revision now requires changes to proceed. Unicode issue is handled by posix.py. The problem is `mockgetuser()` returns a unicode string. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3125 To:

D3125: py3: convert user value to bytes using pycompat.fsencode()

2018-04-05 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY procutil.getuser() can return unicode values. Let's convert them to bytes. This makes test-journal* pass on Python 3.5. REPOSITORY rHG Mercurial REVISION DET