This revision was automatically updated to reflect the committed changes.
Closed by commit rHG1541e1a8e87d: filelog: wrap revlog instead of inheriting it
(API) (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3154?vs=78
indygreg updated this revision to Diff 7860.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3154?vs=7768&id=7860
REVISION DETAIL
https://phab.mercurial-scm.org/D3154
AFFECTED FILES
mercurial/bundlerepo.py
mercurial/filelog.py
mercurial/unionrepo.p
indygreg added a comment.
In https://phab.mercurial-scm.org/D3154#51010, @durin42 wrote:
> test-unionrepo.t:
> + t = self.revision(node)
> +File "/tmp/hgtests.wmoy8H/install/lib/python/mercurial/filelog.py",
line 93, in revision
> + return self._revlog.revision
durin42 added a comment.
test-unionrepo.t:
+ t = self.revision(node)
+File "/tmp/hgtests.wmoy8H/install/lib/python/mercurial/filelog.py",
line 93, in revision
+ return self._revlog.revision(node, _df=_df, raw=raw)
+ TypeError: revision() got an unexpected keywo
indygreg added a comment.
I want to draw attention to this patch for the potential performance concerns.
Like I said in the commit message, I'd love to know what the performance
impact is. I'm just not sure which revlog/filelog attributes/methods are called
in tight loops outside of revl
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
The revlog base class exposes a ton of methods. Inheriting the
revlog class for filelog will make it difficult to expose a
clean interface. There will be abstra
