This revision was automatically updated to reflect the committed changes.
Closed by commit rHGf257943e47ab: repository: formalize peer interface with
abstract base class (authored by indygreg).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D332?vs=847&id=9
indygreg updated this revision to Diff 847.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D332?vs=757&id=847
REVISION DETAIL
https://phab.mercurial-scm.org/D332
AFFECTED FILES
mercurial/repository.py
CHANGE DETAILS
diff --git a/mercurial/repository.
indygreg added inline comments.
INLINE COMMENTS
> durin42 wrote in repository.py:29
> Nit: shouldn't this typically be a connection string with any credentials
> potentially redacted?
I looked at the code and today we're exposing the raw URL, before any
redaction. This raw URL is then fed into
indygreg added inline comments.
INLINE COMMENTS
> durin42 wrote in repository.py:43
> In what cases would a _basepeer not be a peer? What value does this part of
> the interface provide?
TBH, I'm not sure why this exists. I cargo culted it from the existing peer API.
Once this series is accept
durin42 added inline comments.
INLINE COMMENTS
> repository.py:29
> +def url(self):
> +"""Returns a string representing this peer."""
> +
Nit: shouldn't this typically be a connection string with any credentials
potentially redacted?
> repository.py:43
> +
> +Most implement
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
There are various interfaces for interacting with repositories
and peers. They form a contract for how one should interact with
a repo or peer object.
The
