Re: D3590: py3: make sure we pass str to date.strftime()

2018-05-21 Thread Yuya Nishihara
> -return date.strftime(opts['dateformat']) > +return date.strftime(pycompat.sysstr(opts['dateformat'])) Should be `encoding.strfromlocal()` because `opts['dateformat']` is provided by user. ___ Mercurial-devel mailing list Mercur

D3590: py3: make sure we pass str to date.strftime()

2018-05-21 Thread yuja (Yuya Nishihara)
yuja added a comment. > - return date.strftime(opts['dateformat']) +return date.strftime(pycompat.sysstr(opts['dateformat'])) Should be `encoding.strfromlocal()` because `opts['dateformat']` is provided by user. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mer

D3590: py3: make sure we pass str to date.strftime()

2018-05-19 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG543b7b349b2c: py3: make sure we pass str to date.strftime() (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3590?vs=8761&id=87

D3590: py3: make sure we pass str to date.strftime()

2018-05-19 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3590 AFFECTED FILES hgext/churn.py CHANGE DETAILS diff --git a/hgext/churn.py b/hgext/churn.py --- a/h