Re: D3614: py3: check for None before comparing with integers

2018-05-21 Thread Yuya Nishihara
> --- a/mercurial/revlog.py > +++ b/mercurial/revlog.py > @@ -846,7 +846,7 @@ > def rawsize(self, rev): > """return the length of the uncompressed text for a given revision""" > l = self.index[rev][2] > -if l >= 0: > +if l is not None and l >= 0: Ugh, rawsize

D3614: py3: check for None before comparing with integers

2018-05-21 Thread yuja (Yuya Nishihara)
yuja added a comment. > - a/mercurial/revlog.py +++ b/mercurial/revlog.py @@ -846,7 +846,7 @@ def rawsize(self, rev): """return the length of the uncompressed text for a given revision""" l = self.index[rev][2] > - if l >= 0: +if l is not None and l >= 0: Ugh, rawsize could b

D3614: py3: check for None before comparing with integers

2018-05-19 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGa4942675de6b: py3: check for None before comparing with integers (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3614?vs=8785&

D3614: py3: check for None before comparing with integers

2018-05-19 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a reviewer: indygreg. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Comparing None and integers on Python 3 is not allowed and raise error. REPOSITORY rHG Mercurial REVISION DETAIL https://phab