yuja added a comment.
>> --- a/mercurial/utils/stringutil.py
> > +++ b/mercurial/utils/stringutil.py
> > @@ -29,6 +29,8 @@
> > if bprefix:
> > return "b'%s'" % escapestr(o)
> > return "'%s'" % escapestr(o)
> > +elif o is None:
> > +
> > --- a/mercurial/utils/stringutil.py
> > +++ b/mercurial/utils/stringutil.py
> > @@ -29,6 +29,8 @@
> > if bprefix:
> > return "b'%s'" % escapestr(o)
> > return "'%s'" % escapestr(o)
> > +elif o is None:
> > +return 'None'
>
> Should be handled by
> --- a/mercurial/utils/stringutil.py
> +++ b/mercurial/utils/stringutil.py
> @@ -29,6 +29,8 @@
> if bprefix:
> return "b'%s'" % escapestr(o)
> return "'%s'" % escapestr(o)
> +elif o is None:
> +return 'None'
Should be handled by `b'%r' % o`.
yuja added a comment.
> - a/mercurial/utils/stringutil.py +++ b/mercurial/utils/stringutil.py @@
-29,6 +29,8 @@ if bprefix: return "b'%s'" % escapestr(o) return "'%s'" %
escapestr(o) +elif o is None: +return 'None'
Should be handled by `b'%r' % o`.
REPOSITORY
rHG
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG7aeb8aa262eb: py3: add support for NoneType in
stringutil.pprint() (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
There are some places in codebase where we try to print the value None,
however
`'%s' % None` is invalid on Python 3. So it will be good to have support in
