Re: D3684: shelve: merge in obsshelve changes implemented at facebook

2018-06-14 Thread Sean Farley
durin42 (Augie Fackler) writes: > durin42 created this revision. > Herald added a subscriber: mercurial-devel. > Herald added a reviewer: hg-reviewers. > > REVISION SUMMARY > test-obsshelve.t could be merged with test-shelve.t at some point, but > for now I want the comprehensive coverage.

D3684: shelve: merge in obsshelve changes implemented at facebook

2018-06-07 Thread lothiraldan (Boris Feld)
lothiraldan added a comment. In https://phab.mercurial-scm.org/D3684#58106, @durin42 wrote: > In https://phab.mercurial-scm.org/D3684#58074, @lothiraldan wrote: > > > We have an implementation of shelve without strip nor obsmarkers. > > > Can we see that now? Otherwise I'm going

D3684: shelve: merge in obsshelve changes implemented at facebook

2018-06-06 Thread durin42 (Augie Fackler)
durin42 added a comment. In https://phab.mercurial-scm.org/D3684#58074, @lothiraldan wrote: > We have an implementation of shelve without strip nor obsmarkers. Can we see that now? Otherwise I'm going to lobby to land this in the name of having something done. REPOSITORY rHG

D3684: shelve: merge in obsshelve changes implemented at facebook

2018-06-05 Thread lothiraldan (Boris Feld)
lothiraldan added a comment. After reading your obsshelve series, it seems that we have some overlap. We have an implementation of shelve without strip nor obsmarkers. The first series https://phab.mercurial-scm.org/D3685 is the first half, cleaning up the shelve extensions in order

D3684: shelve: merge in obsshelve changes implemented at facebook

2018-06-05 Thread lothiraldan (Boris Feld)
lothiraldan added a comment. We just sent https://phab.mercurial-scm.org/D3685 that update shelve to not use rebase anymore. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3684 To: durin42, #hg-reviewers Cc: lothiraldan, mercurial-devel

D3684: shelve: merge in obsshelve changes implemented at facebook

2018-06-04 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY test-obsshelve.t could be merged with test-shelve.t at some point, but for now I want the comprehensive coverage. Note that obsshelve in hg-experimental is a