mharbison72 added a comment.
In https://phab.mercurial-scm.org/D3699#58394, @lothiraldan wrote:
> @mharbison72 I was not aware that this patch had been merged, is it
breaking the windows build right now?
Yes.
lothiraldan added a comment.
In https://phab.mercurial-scm.org/D3699#58174, @yuja wrote:
> >> test-run-tests.t:1669
> > > + --- $TESTTMP/anothertests/cases/test-cases-advanced-cases.t
> > > + +++
$TESTTMP/anothertests/cases/test-cases-advanced-cases.t.casewith!@#$%^&*()chars.err
> > test-run-tests.t:1669
> > + --- $TESTTMP/anothertests/cases/test-cases-advanced-cases.t
> > + +++
> > $TESTTMP/anothertests/cases/test-cases-advanced-cases.t.casewith!@#$%^&*()chars.err
> > + @@ -1,3 +1,3 @@
>
> Windows can't create the test directory with all of the reserved characters
yuja added a comment.
>> test-run-tests.t:1669
> > + --- $TESTTMP/anothertests/cases/test-cases-advanced-cases.t
> > + +++
$TESTTMP/anothertests/cases/test-cases-advanced-cases.t.casewith!@#$%^&*()chars.err
> > + @@ -1,3 +1,3 @@
>
> Windows can't create the test directory
mharbison72 added inline comments.
INLINE COMMENTS
> test-run-tests.t:1669
> + --- $TESTTMP/anothertests/cases/test-cases-advanced-cases.t
> + +++
> $TESTTMP/anothertests/cases/test-cases-advanced-cases.t.casewith!@#$%^&*()chars.err
> + @@ -1,3 +1,3 @@
Windows can't create the test
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGf2e3196a34f9: run-tests: follow-up on the test-case format
(authored by lothiraldan, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
lothiraldan created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
It turns out the original regex doesn't support real test cases names like the
one Mercurial is using. Update the regex to being able to precisely select
