D3964: macosx: fixing macOS version generation after db9d1dd01bf0

2018-07-19 Thread rdamazio (Rodrigo Damazio Bovendorp)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG25880ddf9a86: macosx: fixing macOS version generation after db9d1dd01bf0 (authored by rdamazio, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D396

D3964: macosx: fixing macOS version generation after db9d1dd01bf0

2018-07-18 Thread rdamazio (Rodrigo Damazio Bovendorp)
rdamazio added a comment. In https://phab.mercurial-scm.org/D3964#61696, @glandium wrote: > This is python code, why is it parsing the version file instead of importing it? Great question, no idea :) I took the minimal fix approach to reduce the change of further breaking it. RE

D3964: macosx: fixing macOS version generation after db9d1dd01bf0

2018-07-18 Thread rdamazio (Rodrigo Damazio Bovendorp)
rdamazio added a comment. Hmm and nevermind, the weird package name doesn't reproduce on a vanilla hg build, you can go ahead and review. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3964 To: rdamazio, #hg-reviewers Cc: glandium, mercurial-devel _

D3964: macosx: fixing macOS version generation after db9d1dd01bf0

2018-07-18 Thread glandium (Mike Hommey)
glandium added a comment. This is python code, why is it parsing the version file instead of importing it? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3964 To: rdamazio, #hg-reviewers Cc: glandium, mercurial-devel

D3964: macosx: fixing macOS version generation after db9d1dd01bf0

2018-07-18 Thread rdamazio (Rodrigo Damazio Bovendorp)
rdamazio added a comment. Er, actually, let me fix this again - this unbreaks the build but generates packages like 'Mercurial-"4.6.2+674-f83600efa1ca-macosx10.13.dmg'. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3964 To: rdamazio, #hg-reviewers Cc: mercuria