This revision now requires changes to proceed.
baymax added a comment.
baymax requested changes to this revision.
There seems to have been no activities on this Diff for the past 3 Months.
By policy, we are automatically moving it out of the `need-review` state.
Please, move it back
quark added a comment.
I think a most flexible solution is to not do the check if there is nothing
to rebase.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D3986
To: martinvonz, #hg-reviewers
Cc: quark, mercurial-devel
martinvonz added a comment.
Oh, I should have said that I agree with not queuing this patch now. We can
discuss what we want to do and do it on the default branch later.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D3986
To: martinvonz, #hg-reviewers
Cc:
martinvonz added a comment.
In https://phab.mercurial-scm.org/D3986#61989, @quark wrote:
> FB has users reporting they need to split commits in the middle of a
histedit. So this might be too restrictive.
Two thoughts:
1. We had talked at Google about having the "edit" action
quark added a comment.
FB has users reporting they need to split commits in the middle of a
histedit. So this might be too restrictive.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D3986
To: martinvonz, #hg-reviewers
Cc: quark, mercurial-devel
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D3986
AFFECTED FILES
hgext/split.py
tests/test-split.t
CHANGE DETAILS
diff --git
