D4284: copies: correctly skip directories that have already been considered

2018-08-24 Thread spectral (Kyle Lippincott)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGeebd591803ab: copies: correctly skip directories that have already been considered (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-sc

D4284: copies: correctly skip directories that have already been considered

2018-08-24 Thread spectral (Kyle Lippincott)
spectral added inline comments. INLINE COMMENTS > jpsugar wrote in copies.py:615 > Maybe do this after the debug loop to avoid an un-pretty output? I personally have no preference, but had been trying to make this an unobservable difference, whereas that is technically observable (though I doub

D4284: copies: correctly skip directories that have already been considered

2018-08-24 Thread jpsugar (JP Sugarbroad)
jpsugar added inline comments. INLINE COMMENTS > copies.py:615 > > +dirmove = {k + "/": v + "/" for k, v in dirmove.iteritems()} > + Maybe do this after the debug loop to avoid an un-pretty output? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4284 To: spe

D4284: copies: correctly skip directories that have already been considered

2018-08-15 Thread spectral (Kyle Lippincott)
spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Previously, `if dsrc in invalid` would never be true, since we added `dsrc + "/"` to invalid, not `dsrc` itself. Since it's much more common for individual file