D4788: narrow: don't do the dirstate dance if ellipses is not enabled

This revision was automatically updated to reflect the committed changes. Closed by commit rHG693dda764efe: narrow: dont do the dirstate dance if ellipses is not enabled (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4788: narrow: don't do the dirstate dance if ellipses is not enabled

martinvonz accepted this revision. martinvonz added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > narrowcommands.py:286-287 > +ds.setparents(node.nullid, node.nullid) > +with wrappedextraprepare,\ > +

D4788: narrow: don't do the dirstate dance if ellipses is not enabled

pulkit updated this revision to Diff 11517. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4788?vs=11502=11517 REVISION DETAIL https://phab.mercurial-scm.org/D4788 AFFECTED FILES hgext/narrow/narrowcommands.py tests/test-narrow-widen-no-ellipsis.t

D4788: narrow: don't do the dirstate dance if ellipses is not enabled

pulkit added a comment. In https://phab.mercurial-scm.org/D4788#72714, @martinvonz wrote: > In https://phab.mercurial-scm.org/D4788#72444, @pulkit wrote: > > > I am not sure about this one. I was unable to think of a reason why we need to do this dirstate dance in non-ellipses cases.

D4788: narrow: don't do the dirstate dance if ellipses is not enabled

martinvonz added a comment. In https://phab.mercurial-scm.org/D4788#72444, @pulkit wrote: > I am not sure about this one. I was unable to think of a reason why we need to do this dirstate dance in non-ellipses cases. @martinvonz @durin42 do you know why we do this? What I

D4788: narrow: don't do the dirstate dance if ellipses is not enabled

pulkit updated this revision to Diff 11502. pulkit edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4788?vs=11471=11502 REVISION DETAIL https://phab.mercurial-scm.org/D4788 AFFECTED FILES

D4788: narrow: don't do the dirstate dance if ellipses is not enabled

pulkit added a subscriber: martinvonz. pulkit added a comment. I am not sure about this one. I was unable to think of a reason why we need to do this dirstate dance in non-ellipses cases. @martinvonz @durin42 do you know why we do this? REPOSITORY rHG Mercurial REVISION DETAIL

D4788: narrow: don't do the dirstate dance if ellipses is not enabled

pulkit created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I believe we set dirstate parents to nullid before widening pull because in ellipses cases, the parent might be stripped off with