This revision was automatically updated to reflect the committed changes.
Closed by commit rHGa24f4638d6c1: narrow: move the ellipses server capability
to core (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4809?vs=1151
martinvonz added a comment.
btw, "narrow: move the ellipses server capability to core" should probably be
changed to more closely match "narrow: move the ellipses server capability to
core"
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4809
To: pulkit, durin4
pulkit added a comment.
@martinvonz I have removed the logic of adding a new ellipses requirement
from current series as coupling that and this series for review turned out to
be a bad idea. This series now only tries to do some cleanup and introduce a
new wireprotocol command.
REPOSITORY
pulkit updated this revision to Diff 11516.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4809?vs=11500&id=11516
REVISION DETAIL
https://phab.mercurial-scm.org/D4809
AFFECTED FILES
hgext/narrow/narrowcommands.py
hgext/narrow/narrowrepo.py
hgext/n
martinvonz added inline comments.
INLINE COMMENTS
> martinvonz wrote in hg.py:582-583
> This patch seems to do more than what it says, and more than what the
> previous patch did. Can we separate out this functional change? IIUC, this
> makes it so we start writing the ellipses requirement to t
martinvonz added inline comments.
INLINE COMMENTS
> hg.py:582-583
>
> +if srcpeer.capable(wireprotoserver.ELLIPSESCAP):
> +createopts['ellipses'] = True
> +
This patch seems to do more than what it says, and more than what the previous
patch did. Can we separate out this f
pulkit added inline comments.
INLINE COMMENTS
> martinvonz wrote in test-narrow-clone.t:48
> This doesn't look right. I suspect it was done by a mistaken `run-tests.py -i`
I just ran `run-tests.py -i` and it popped up and I accepted it. I will check
if the test pass without this change or not.
martinvonz added inline comments.
INLINE COMMENTS
> test-narrow-clone.t:48
> + testonly-simplestore (reposimplestore !)
>store
>
This doesn't look right. I suspect it was done by a mistaken `run-tests.py -i`
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D48
pulkit updated this revision to Diff 11500.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4809?vs=11492&id=11500
REVISION DETAIL
https://phab.mercurial-scm.org/D4809
AFFECTED FILES
hgext/narrow/__init__.py
hgext/narrow/narrowcommands.py
hgext/nar
pulkit created this revision.
Herald added a reviewer: durin42.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This will be used in core logic to determining whether a server is ellipses
enabled or not. And also this will ease moving narrow
10 matches
Mail list logo
