durin42 requested changes to this revision.
durin42 added a comment.
This revision now requires changes to proceed.
It sounds like @pulkit has some ideas on what needs to be done follow-up wise.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4876
To:
yuja added a comment.
> I should be easy to introduce such an option and make amend respect it
(similar amount of code as this patch), so I'd just like to hear if others
think it's a good idea first. If others agree with it, then it seems better to
introduce the generic option right away.
> I should be easy to introduce such an option and make amend respect it
> (similar amount of code as this patch), so I'd just like to hear if others
> think it's a good idea first. If others agree with it, then it seems better
> to introduce the generic option right away. I can't/won't
martinvonz added a comment.
In https://phab.mercurial-scm.org/D4876#74021, @pulkit wrote:
> (Replying because I adviced Zharas to take up this issue and he is a new
mercurial user and have less context on the problem)
>
> In https://phab.mercurial-scm.org/D4876#74017, @martinvonz
pulkit added a comment.
(Replying because I adviced Zharas to take up this issue and he is a new
mercurial user and have less context on the problem)
In https://phab.mercurial-scm.org/D4876#74017, @martinvonz wrote:
> I'm not sure how I feel about this. I think we talked within the
martinvonz added a comment.
I'm not sure how I feel about this. I think we talked within the team at
Google about always passing a `-D now` and decided not to do it because of the
issue you're fixing here (I may be confusing the discussion with one about
using `hg metaedit`). Still, I feel
pulkit accepted this revision.
pulkit added a comment.
This looks good to me but since I helped Zharas in preparing the patch, I
won't queue it.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4876
To: Zharaskhan, #hg-reviewers, pulkit
Cc: pulkit,
Zharaskhan created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
When --date flag specified with `hg amend` and working copy is clean,
`hg amend` amends, which is generally undesirable behavior.
But it is commonly used to
