D4887: narrow: don't include the manifests while widening a narrow clone

2018-11-13 Thread pulkit (Pulkit Goyal)
pulkit abandoned this revision. pulkit added a comment. Abandoing this one and https://phab.mercurial-scm.org/D4886 as @martinvonz's better fix landed as https://phab.mercurial-scm.org/D4895. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4887 To: pulkit,

D4887: narrow: don't include the manifests while widening a narrow clone

2018-10-05 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 11706. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4887?vs=11700=11706 REVISION DETAIL https://phab.mercurial-scm.org/D4887 AFFECTED FILES mercurial/bundle2.py mercurial/changegroup.py CHANGE DETAILS diff

D4887: narrow: don't include the manifests while widening a narrow clone

2018-10-05 Thread pulkit (Pulkit Goyal)
pulkit added a comment. In https://phab.mercurial-scm.org/D4887#73793, @martinvonz wrote: > > I'm still fine with queuing this for now if you need this patch somewhat urgently even though I think the code in this patch and in https://phab.mercurial-scm.org/D4886 should

D4887: narrow: don't include the manifests while widening a narrow clone

2018-10-05 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. I don't think this is quite the right approach. If we're using treemanifest and widening from `{foo/, bar/}` to `{foo/, bar/, baz/}`, then we'd still be sending manifests for all those directories (and their subdirectories, right)? We should only have to send

D4887: narrow: don't include the manifests while widening a narrow clone

2018-10-05 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a reviewer: durin42. Herald added a reviewer: martinvonz. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY When a narrow clone is done initially the whole manifest is send. In case of treemanifests,