D4894: py3: use '%f' for floats instead of '%s'

2018-10-05 Thread yuja (Yuya Nishihara)
yuja added a comment. > I remember Yuya saying we need to use bytestr() or '%r' because '%s' was clever. > Not sure it applies to this or not. This should be fine since we don't care the prettiness of the debug output. Last time, I pointed out that '%f' was incompatible since

Re: D4894: py3: use '%f' for floats instead of '%s'

2018-10-05 Thread Yuya Nishihara
> I remember Yuya saying we need to use bytestr() or '%r' because '%s' was > clever. > Not sure it applies to this or not. This should be fine since we don't care the prettiness of the debug output. Last time, I pointed out that '%f' was incompatible since the value was a version number,

D4894: py3: use '%f' for floats instead of '%s'

2018-10-05 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG2e9378f62232: py3: use %f for floats instead of %s (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4894?vs=11713=11718

D4894: py3: use '%f' for floats instead of '%s'

2018-10-05 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I remember Yuya saying we need to use bytestr() or '%r' because '%s' was clever. Not sure it applies to this or not. REPOSITORY rHG Mercurial REVISION DETAIL