D4895: RFC: narrow: don't include manifests the client already has

2018-10-05 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is what I had in mind as an alternative to https://phab.mercurial-scm.org/D4887. This should not include subdirectory ma

D4895: RFC: narrow: don't include manifests the client already has

2018-10-05 Thread pulkit (Pulkit Goyal)
pulkit added a comment. @martinvonz Thanks a lot for putting time and effort in trying alternate approach. Sadly this does not work. I didn't tested this on our repo yet, but I tested this on test-narrow-widen-no-ellipsis.t. You can also do that, by removing the globs from this line https:/

D4895: RFC: narrow: don't include manifests the client already has

2018-10-05 Thread pulkit (Pulkit Goyal)
pulkit added inline comments. INLINE COMMENTS > changegroup.py:1056 > > -yield tree, deltas > +if not tree or not self._oldfilematcher.visitdir(store.tree[:-1] > or '.'): > +yield tree, deltas Also, I think this is not the right place to case this becau

D4895: RFC: narrow: don't include manifests the client already has

2018-10-14 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 12129. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4895?vs=11714&id=12129 REVISION DETAIL https://phab.mercurial-scm.org/D4895 AFFECTED FILES hgext/narrow/narrowwirepeer.py mercurial/bundle2.py mercurial

D4895: RFC: narrow: don't include manifests the client already has

2018-10-14 Thread pulkit (Pulkit Goyal)
pulkit added a comment. This patch is now waiting for me to test it on our internal repo and make sure it works on multi-level dirs and big repos. Since this a server side fix, it will take some time for me to test this internally and I will try to do it in next couple of days. Also this is