D5002: extensions: fix up many many debug logs that use %r

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This gets us a bunch closer on Python 3, but I'll still have to use a ton of sad globs. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.o

D5002: extensions: fix up many many debug logs that use %r

indygreg requested changes to this revision. indygreg added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > extensions.py:178 > return _extensions[shortname] > -log(' - loading extension: %r\n', shortname) > +log(' - loading extension: %r\n', p

D5002: extensions: fix up many many debug logs that use %r

durin42 added a comment. Switching to %s loses some quotes I like having. INLINE COMMENTS > indygreg wrote in extensions.py:178 > Can't we just switch to `%s`? That'll result in less quoting in the output, and I like having the quoting. REPOSITORY rHG Mercurial REVISION DETAIL https://

D5002: extensions: fix up many many debug logs that use %r

pulkit added a comment. How do we want to move forward with this? 1. use pycompat.bytestr() as this patch does 2. use '%s' and add quotes in the output This is one the failure breaking python3-buildbot. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5

D5002: extensions: fix up many many debug logs that use %r

yuja added a comment. > 1. use pycompat.bytestr() as this patch does > 2. use '%s' and add quotes in the output I think they can be just "... '%s'" given extension names are unlikely to contain meta characters. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.o

D5002: extensions: fix up many many debug logs that use %r

durin42 updated this revision to Diff 12323. durin42 edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5002?vs=11910&id=12323 REVISION DETAIL https://phab.mercurial-scm.org/D5002 AFFECTED FILES mercurial/extensions.py

D5002: extensions: fix up many many debug logs that use %r

This revision was automatically updated to reflect the committed changes. Closed by commit rHG09a37a5d8f5d: extensions: fix up many many debug logs that use %r (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5002?vs=123

Re: D5002: extensions: fix up many many debug logs that use %r

> 1. use pycompat.bytestr() as this patch does > 2. use '%s' and add quotes in the output I think they can be just "... '%s'" given extension names are unlikely to contain meta characters. ___ Mercurial-devel mailing list Mercurial-devel@mercurial-sc