D5105: style: drop requirement to only use single lines between top-level objects

2018-10-16 Thread mjpieters (Martijn Pieters)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG47084b5ffd80: style: drop requirement to only use single lines between top-level objects (authored by mjpieters, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5105: style: drop requirement to only use single lines between top-level objects

2018-10-16 Thread indygreg (Gregory Szorc)
indygreg accepted this revision. indygreg added a comment. This revision is now accepted and ready to land. At the 4.8 sprint, we agreed to repo mass rewriting with style that is more PEP-8 like. The tentative plan is to use black, which is very opinionated and doesn't give us much room for

D5105: style: drop requirement to only use single lines between top-level objects

2018-10-14 Thread durin42 (Augie Fackler)
durin42 accepted this revision as: durin42. durin42 added a comment. I'm in favor, but want to see a broader set of thoughts on this. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5105 To: mjpieters, #hg-reviewers, durin42 Cc: durin42, indygreg,

D5105: style: drop requirement to only use single lines between top-level objects

2018-10-14 Thread mjpieters (Martijn Pieters)
mjpieters added a subscriber: indygreg. mjpieters added a comment. This was split out from https://phab.mercurial-scm.org/D5064 (cc @indygreg ) REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5105 To: mjpieters, #hg-reviewers Cc: indygreg, mercurial-devel

D5105: style: drop requirement to only use single lines between top-level objects

2018-10-14 Thread mjpieters (Martijn Pieters)
mjpieters created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5105 AFFECTED FILES contrib/check-commit CHANGE DETAILS diff --git a/contrib/check-commit