D5194: wireprotov2: add an extension to cache wireproto v2 responses in S3

2018-11-02 Thread sheehan (Connor Sheehan)
sheehan abandoned this revision. sheehan added a comment. > Either way, we'll be deploying this to Mozilla's hg servers in the next few months and testing it out. Perhaps after it's been in production for some time we will have a stronger case for inclusion in core. :) Going to deploy

D5194: wireprotov2: add an extension to cache wireproto v2 responses in S3

2018-10-31 Thread indygreg (Gregory Szorc)
indygreg added a comment. In https://phab.mercurial-scm.org/D5194#77606, @martinvonz wrote: > Is this useful enough to others that it should live in the hg core repo? It doesn't seem like it to me, but maybe I'm wrong. I think having plug-and-play caching solutions in the

D5194: wireprotov2: add an extension to cache wireproto v2 responses in S3

2018-10-30 Thread sheehan (Connor Sheehan)
sheehan added a comment. In https://phab.mercurial-scm.org/D5194#77606, @martinvonz wrote: > Is this useful enough to others that it should live in the hg core repo? It doesn't seem like it to me, but maybe I'm wrong. My thought process was that since the new wire protocol

D5194: wireprotov2: add an extension to cache wireproto v2 responses in S3

2018-10-26 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. Is this useful enough to others that it should live in the hg core repo? It doesn't seem like it to me, but maybe I'm wrong. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5194 To: sheehan, #hg-reviewers Cc: martinvonz, indygreg,

D5194: wireprotov2: add an extension to cache wireproto v2 responses in S3

2018-10-26 Thread sheehan (Connor Sheehan)
sheehan added a subscriber: indygreg. sheehan added a comment. Throwing this up for review now, but there are a few things that could be done to improve this. A cache expiration policy might be useful, but is difficult to test with the S3 bucket expiration rules. It may also be desirable to

D5194: wireprotov2: add an extension to cache wireproto v2 responses in S3

2018-10-26 Thread sheehan (Connor Sheehan)
sheehan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY With wireprotocol version two introducing command response caching and enabling content redirect responses, it is possible to store response objects in an