D5287: py3: use node.hex(m.digest()) instead of m.hexdigest()

2018-11-21 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG9fcf8084ada8: py3: use node.hex(m.digest()) instead of m.hexdigest() (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5287: py3: use node.hex(m.digest()) instead of m.hexdigest()

2018-11-21 Thread yuja (Yuya Nishihara)
yuja added a comment. > > hgext/remotefilelog/basepack.py:472: import 'node' from line 12 shadowed by loop variable > > Looks like a False positive/negative. Might be, but it's better to not shadow global names by local ones. Queued, thanks. REPOSITORY rHG Mercurial

Re: D5287: py3: use node.hex(m.digest()) instead of m.hexdigest()

2018-11-21 Thread Yuya Nishihara
> > hgext/remotefilelog/basepack.py:472: import 'node' from line 12 shadowed > by loop variable > > Looks like a False positive/negative. Might be, but it's better to not shadow global names by local ones. Queued, thanks. ___ Mercurial-devel

D5287: py3: use node.hex(m.digest()) instead of m.hexdigest()

2018-11-20 Thread pulkit (Pulkit Goyal)
pulkit added a comment. In https://phab.mercurial-scm.org/D5287#78759, @yuja wrote: > > diff --git a/hgext/remotefilelog/basepack.py b/hgext/remotefilelog/basepack.py > > > > - a/hgext/remotefilelog/basepack.py +++ b/hgext/remotefilelog/basepack.py @@ -10,6 +10,7 @@ > > > >

D5287: py3: use node.hex(m.digest()) instead of m.hexdigest()

2018-11-20 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 12574. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5287?vs=12563=12574 REVISION DETAIL https://phab.mercurial-scm.org/D5287 AFFECTED FILES hgext/fastannotate/context.py hgext/largefiles/lfcommands.py

D5287: py3: use node.hex(m.digest()) instead of m.hexdigest()

2018-11-20 Thread yuja (Yuya Nishihara)
yuja added a comment. > diff --git a/hgext/remotefilelog/basepack.py b/hgext/remotefilelog/basepack.py > > - a/hgext/remotefilelog/basepack.py +++ b/hgext/remotefilelog/basepack.py @@ -10,6 +10,7 @@ > > from mercurial.i18n import _ from mercurial import ( +node,

Re: D5287: py3: use node.hex(m.digest()) instead of m.hexdigest()

2018-11-20 Thread Yuya Nishihara
> diff --git a/hgext/remotefilelog/basepack.py b/hgext/remotefilelog/basepack.py > --- a/hgext/remotefilelog/basepack.py > +++ b/hgext/remotefilelog/basepack.py > @@ -10,6 +10,7 @@ > > from mercurial.i18n import _ > from mercurial import ( > +node, hgext/remotefilelog/basepack.py:472:

D5287: py3: use node.hex(m.digest()) instead of m.hexdigest()

2018-11-19 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY hashlib.sha1.hexdigest() returns str on Python 3. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5287 AFFECTED FILES