D5290: branchmap: refactor for better encapsulation

2018-11-23 Thread yuja (Yuya Nishihara)
yuja added a comment. Can you split this to a couple of patches? The idea sounds good, but it isn't easy to review formatting changes, code moves, and interface improvements as a single patch. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5290 To: mjpiet

Re: D5290: branchmap: refactor for better encapsulation

2018-11-23 Thread Yuya Nishihara
Can you split this to a couple of patches? The idea sounds good, but it isn't easy to review formatting changes, code moves, and interface improvements as a single patch. ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.merc

D5290: branchmap: refactor for better encapsulation

2018-11-22 Thread mjpieters (Martijn Pieters)
mjpieters added a comment. The goal of this refactor is to bring clarity to the branchmap cache behaviour, and to make it easier to add performance improvements (in an upcoming additional series of patches). REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5290

D5290: branchmap: refactor for better encapsulation

2018-11-20 Thread mjpieters (Martijn Pieters)
mjpieters created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5290 AFFECTED FILES contrib/perf.py mercurial/branchmap.py mercurial/discovery.py mercurial/loc