D5435: rust: better treatment of cargo/rustc errors

2018-12-15 Thread gracinet (Georges Racinet)
gracinet created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5435 AFFECTED FILES setup.py CHANGE DETAILS diff --git a/setup.py b/setup.py --- a/setup.py +++ b/se

D5435: rust: better treatment of cargo/rustc errors

2018-12-15 Thread yuja (Yuya Nishihara)
yuja added a comment. > +cargocmd = ['cargo', 'build', '-vv', '--release'] > +try: > +subprocess.check_call(cargocmd, env=env, cwd=self.rustsrcdir) > +except OSError as exc: > +if exc.errno == os.errno.ENOENT: Added `import errno`

D5435: rust: better treatment of cargo/rustc errors

2018-12-15 Thread gracinet (Georges Racinet)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG5955cf85ed74: rust: better treatment of cargo/rustc errors (authored by gracinet, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D5435?vs=12872&id=12884#toc REPOSITORY rHG Me

Re: D5435: rust: better treatment of cargo/rustc errors

2018-12-15 Thread Yuya Nishihara
> +cargocmd = ['cargo', 'build', '-vv', '--release'] > +try: > +subprocess.check_call(cargocmd, env=env, cwd=self.rustsrcdir) > +except OSError as exc: > +if exc.errno == os.errno.ENOENT: Added `import errno` to not abuse `os.errno`. I don't think it