D5490: commit: remove ignore whitespace option on --interactive (issue6042)

Herald added a subscriber: mercurial-patches. KenyaCollier added a comment. Your ideas are incredible. The way of encouraging the new talent is truly good and completely amazing. I have been looking for high school essay writing blogs and

D5490: commit: remove ignore whitespace option on --interactive (issue6042)

navaneeth.suresh abandoned this revision. navaneeth.suresh added a comment. https://phab.mercurial-scm.org/rHG66399f2e92aac38855caab69a4c0acafead90c91 solves this issue, many thanks @spectral. Closing this. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5490

D5490: commit: remove ignore whitespace option on --interactive (issue6042)

yuja added a comment. > @spectral @yuja Can I close this? Probably yes. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5490 To: navaneeth.suresh, #hg-reviewers Cc: spectral, yuja, durin42, pulkit, mercurial-devel

Re: D5490: commit: remove ignore whitespace option on --interactive (issue6042)

> @spectral @yuja Can I close this? Probably yes. ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

D5490: commit: remove ignore whitespace option on --interactive (issue6042)

navaneeth.suresh added a subscriber: spectral. navaneeth.suresh added a comment. @spectral @yuja Can I close this? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5490 To: navaneeth.suresh, #hg-reviewers Cc: spectral, yuja, durin42, pulkit, mercurial-devel

D5490: commit: remove ignore whitespace option on --interactive (issue6042)

yuja added a comment. > > `_performrevert()` would be in the same boat, but it was explicitly flagged on > > at https://phab.mercurial-scm.org/rHGf37a69ec3f4717fdb4f00699ca06c225f106696c. This implies that the `diff.ignorews` option would be used > > in practice to exclude

Re: D5490: commit: remove ignore whitespace option on --interactive (issue6042)

> > `_performrevert()` would be in the same boat, but it was explicitly > flagged on > > at > https://phab.mercurial-scm.org/rHGf37a69ec3f4717fdb4f00699ca06c225f106696c. > This implies that the `diff.ignorews` option would be used > > in practice to exclude whitespace changes while

D5490: commit: remove ignore whitespace option on --interactive (issue6042)

navaneeth.suresh added a comment. > `_performrevert()` would be in the same boat, but it was explicitly flagged on > at https://phab.mercurial-scm.org/rHGf37a69ec3f4717fdb4f00699ca06c225f106696c. This implies that the `diff.ignorews` option would be used > in practice to exclude

D5490: commit: remove ignore whitespace option on --interactive (issue6042)

yuja added a comment. > > It was intentionally added by https://phab.mercurial-scm.org/rHG3f1dccea9510c122cf9ab0e7a5a19ceed3600a7f (with no tests.) > > Do you want me to add tests for that? If yes, please mention the things I need to take care of on >writing those tests.

Re: D5490: commit: remove ignore whitespace option on --interactive (issue6042)

> > It was intentionally added by > https://phab.mercurial-scm.org/rHG3f1dccea9510c122cf9ab0e7a5a19ceed3600a7f > (with no tests.) > > Do you want me to add tests for that? If yes, please mention the things I > need to take care of on >writing those tests. I think you can reuse the

D5490: commit: remove ignore whitespace option on --interactive (issue6042)

yuja added a comment. > - a/mercurial/cmdutil.py +++ b/mercurial/cmdutil.py @@ -237,6 +237,7 @@ def dorecord(ui, repo, commitfunc, cmdsuggest, backupall, filterfn, *pats, **opts): opts = pycompat.byteskwargs(opts) +ignorews = opts.get('ignorews', False) It isn't nice to mix command

Re: D5490: commit: remove ignore whitespace option on --interactive (issue6042)

> --- a/mercurial/cmdutil.py > +++ b/mercurial/cmdutil.py > @@ -237,6 +237,7 @@ > def dorecord(ui, repo, commitfunc, cmdsuggest, backupall, > filterfn, *pats, **opts): > opts = pycompat.byteskwargs(opts) > +ignorews = opts.get('ignorews', False) It isn't nice to mix command

D5490: commit: remove ignore whitespace option on --interactive (issue6042)

navaneeth.suresh added a comment. > Sorry for late, but doesn't it break `hg record --ignore-all-space`, etc.? Yes. Exactly! Thanks for pointing that out. > It was intentionally added by https://phab.mercurial-scm.org/rHG3f1dccea9510c122cf9ab0e7a5a19ceed3600a7f (with no tests.)

D5490: commit: remove ignore whitespace option on --interactive (issue6042)

navaneeth.suresh updated this revision to Diff 13177. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5490?vs=13166=13177 REVISION DETAIL https://phab.mercurial-scm.org/D5490 AFFECTED FILES hgext/record.py mercurial/cmdutil.py

D5490: commit: remove ignore whitespace option on --interactive (issue6042)

yuja added a comment. > - diffopts = patch.difffeatureopts(ui, opts=opts, whitespace=True) + diffopts = patch.difffeatureopts(ui, opts=opts) Sorry for late, but doesn't it break `hg record --ignore-all-space`, etc.? It was intentionally added by

Re: D5490: commit: remove ignore whitespace option on --interactive (issue6042)

> -diffopts = patch.difffeatureopts(ui, opts=opts, whitespace=True) > +diffopts = patch.difffeatureopts(ui, opts=opts) Sorry for late, but doesn't it break `hg record --ignore-all-space`, etc.? It was intentionally added by 3f1dccea9510 (with no tests.)

D5490: commit: remove ignore whitespace option on --interactive (issue6042)

navaneeth.suresh added a comment. @durin42 I've added test for the current revision. Unfortunately, I'm unable to write a test for the wrong behaviour. I'll try writing it again. Any hints from your side? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5490

D5490: commit: remove ignore whitespace option on --interactive (issue6042)

navaneeth.suresh updated this revision to Diff 13166. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5490?vs=13003=13166 REVISION DETAIL https://phab.mercurial-scm.org/D5490 AFFECTED FILES mercurial/cmdutil.py tests/test-commit-interactive.t

D5490: commit: remove ignore whitespace option on --interactive (issue6042)

navaneeth.suresh added a comment. > Could you add a test? > > (Bonus points if you add a test that shows the wrong behavior and then fix it in this change.) Sure. Will do. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5490 To: navaneeth.suresh,

D5490: commit: remove ignore whitespace option on --interactive (issue6042)

durin42 added a comment. Could you add a test? (Bonus points if you add a test that shows the wrong behavior and then fix it in this change.) REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5490 To: navaneeth.suresh, #hg-reviewers Cc: durin42, pulkit,

D5490: commit: remove ignore whitespace option on --interactive (issue6042)

navaneeth.suresh added a comment. In https://phab.mercurial-scm.org/D5490#81294, @pulkit wrote: > I am not sure whether this change is correct or not, but please add more description to your commit message explaining what this patch is doing, what the issue is about and how it fixes

D5490: commit: remove ignore whitespace option on --interactive (issue6042)

pulkit added a comment. I am not sure whether this change is correct or not, but please add more description to your commit message explaining what this patch is doing, what the issue is about and how it fixes that. REPOSITORY rHG Mercurial REVISION DETAIL

D5490: commit: remove ignore whitespace option on --interactive (issue6042)

navaneeth.suresh created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5490 AFFECTED FILES mercurial/cmdutil.py CHANGE DETAILS diff --git a/mercurial/cmdutil.py