This revision was automatically updated to reflect the committed changes.
Closed by commit rHGbf7fb97aecf1: branchmap: make branchcache responsible for
reading (authored by mjpieters, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
mjpieters updated this revision to Diff 13542.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5635?vs=13501=13542
REVISION DETAIL
https://phab.mercurial-scm.org/D5635
AFFECTED FILES
contrib/perf.py
mercurial/branchmap.py
CHANGE DETAILS
diff --git
yuja added a comment.
>> Why is that? @yuja, can you elaborate?
> >
> > This is version-controlled code that changes in lock-step with the
branchmap module, adding backwards compatibility tests here would add a costly
maintenance burden. If you have an older revision of the branchmap
> > Why is that? @yuja, can you elaborate?
> >
> > This is version-controlled code that changes in lock-step with the
> > branchmap module, adding backwards compatibility tests here would add a
> > costly maintenance burden. If you have an older revision of the branchmap
> > module, you also
martinvonz added inline comments.
INLINE COMMENTS
> mjpieters wrote in perf.py:2326
> Why is that? @yuja, can you elaborate?
>
> This is version-controlled code that changes in lock-step with the branchmap
> module, adding backwards compatibility tests here would add a costly
> maintenance
mjpieters updated this revision to Diff 13501.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5635?vs=13330=13501
REVISION DETAIL
https://phab.mercurial-scm.org/D5635
AFFECTED FILES
contrib/perf.py
mercurial/branchmap.py
CHANGE DETAILS
diff --git
mjpieters added a subscriber: yuja.
mjpieters added inline comments.
INLINE COMMENTS
> martinvonz wrote in perf.py:2326
> As I was recently reminded by Yuya, the perf commands are supposed to be
> compatible with older versions of hg too, and this doesn't seem to be
> compatible with the
martinvonz added inline comments.
INLINE COMMENTS
> perf.py:2326
>
> -branchcacheread = safeattrsetter(branchmap, b'read')
> +branchcacheread = safeattrsetter(branchmap.branchcache, b'fromfile')
> branchcachewrite = safeattrsetter(branchmap.branchcache, b'write')
As I was
mjpieters created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Encapsulate reading in a classmethod, to make it clear what kind of object is
being handled.
This is part of a stack of refactoring changes to help
