This revision was automatically updated to reflect the committed changes.
Closed by commit rHGeb7ce452e0fb: branchmap: updating triggers a write
(authored by mjpieters, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5636?vs=13331=13807
mjpieters added inline comments.
INLINE COMMENTS
> martinvonz wrote in discovery.py:242-243
> Indentation seems bad (seemed bad before too)
It's a generator expression as single argument. I was deliberately not making
style changes in these patches, so I didn't touch the indentation here.
If
martinvonz added inline comments.
INLINE COMMENTS
> discovery.py:242-243
> +newmap = branchmap.remotebranchcache((branch, heads[1])
> for branch, heads in headssum.iteritems()
> if heads[0] is not None)
>
mjpieters created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Rather than separate updating and writing, create a subclass that doesn't
write
on update. This minimises chances we forget to write out updates somewhere.
