This revision was automatically updated to reflect the committed changes.
Closed by commit rHG8db09278f7e0: tags: avoid generating commit for an already
deleted tag (issue5752) (authored by navaneeth.suresh, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
navaneeth.suresh added a comment.
@durin42 Thanks for the quick review.
@mharbison72 Yup. I should not be making changes to the ui as this can be
fixed simply within the call itself. My bad. I've updated the revision as per
your suggestion, many thanks!
REPOSITORY
rHG Mercurial
navaneeth.suresh updated this revision to Diff 13647.
navaneeth.suresh edited the summary of this revision.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5780?vs=13641=13647
REVISION DETAIL
https://phab.mercurial-scm.org/D5780
AFFECTED FILES
mharbison72 added a comment.
Since the tag command's code is already looking at `repo.tagtype()`, I wonder
if it would be better to just inline the global tag lookup and nullid
comparison right there instead of updating the interface.
REPOSITORY
rHG Mercurial
REVISION DETAIL
durin42 requested changes to this revision.
durin42 added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> localrepo.py:1484
>
> +def alreadydeletedtag(self, tagname):
> +'''return True if given tag is already deleted'''
You'll need to update the
navaneeth.suresh created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
`$ hg tag --remove ` will keep on generating commits
regardless of checking whether the tag is deleted or not. I added a new
function
