navaneeth.suresh created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
The behaviour of uncommit may confuse a new user. Although it never
destroys the data, it can hide instead. I added a `-f/--force` flag
when the working
pulkit added a comment.
Hi, it will be good if you specify that the patch is authored by someone
else, mention their name and also provide the link to the original PR of this
patch.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5940
To: navaneeth.suresh, #hg-
navaneeth.suresh added a comment.
In https://phab.mercurial-scm.org/D5940#87026, @pulkit wrote:
> Hi, it will be good if you specify that the patch is authored by someone
else, mention their name and also provide the link to the original PR of this
patch.
@pulkit the link of WIP
pulkit added a comment.
In https://phab.mercurial-scm.org/D5940#87087, @navaneeth.suresh wrote:
> In https://phab.mercurial-scm.org/D5940#87026, @pulkit wrote:
>
> > Hi, it will be good if you specify that the patch is authored by someone
else, mention their name and also provide the
navaneeth.suresh updated this revision to Diff 14096.
navaneeth.suresh edited the summary of this revision.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5940?vs=14036&id=14096
REVISION DETAIL
https://phab.mercurial-scm.org/D5940
AFFECTED FILES
hgext
martinvonz added inline comments.
INLINE COMMENTS
> test-uncommit.t:176-179
>$ hg uncommit --config experimental.uncommitondirtywdir=True
> + abort: uncommitted changes
> + (use -f to force)
> + [255]
Why did this change?
I don't understand what the new flag is for since we already how t
navaneeth.suresh added inline comments.
INLINE COMMENTS
> martinvonz wrote in test-uncommit.t:176-179
> Why did this change?
>
> I don't understand what the new flag is for since we already how the config
> option. They seem to me to do the same thing.
I'm also surprised at the change in that
martinvonz added inline comments.
INLINE COMMENTS
> uncommit.py:140
> [('', 'keep', False, _('allow an empty commit after uncommiting')),
> + ('f', 'force', False, _('allow uncommit with outstanding changes')),
> ] + commands.walkopts,
Could you rename --force to e.g. --allow-dirty
