This revision was automatically updated to reflect the committed changes.
Closed by commit rHG6b94f8249eaf: bundle2: handle compression in _forwardchunks
(authored by joerg.sonnenberger, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6182?v
joerg.sonnenberger added inline comments.
INLINE COMMENTS
> durin42 wrote in bundle2.py:846
> so...what's going on with oparams here? should it be outparams?
>
> (is there more to this series that would get this code covered by tests?)
Yes, left-over from earlier rename round. I think the code
joerg.sonnenberger updated this revision to Diff 14786.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6182?vs=14622&id=14786
REVISION DETAIL
https://phab.mercurial-scm.org/D6182
AFFECTED FILES
mercurial/bundle2.py
tests/test-pull-bundle.t
CHANGE D
durin42 added a comment.
Ugh I'm sorry - I evidently reviewed this and never pushed submit. :(
INLINE COMMENTS
> bundle2.py:846
> +if k.lower() != 'compression':
> +oparams.append(p)
> +outparams = ' '.join(outparams)
so...what's going on with
joerg.sonnenberger created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
_forwardchunks is used to compensate for getbundle protocol deficits.
Since it transparently decodes the payload, it also needs to remove the
correspo