martinvonz added a comment.
In https://phab.mercurial-scm.org/D6183#91062, @indygreg wrote:
> An idea to consider (which may have been proposed already) is to write a
*no copy metadata* entry into extras when writing copy metadata to the
changelog. If we did things this way, a new client
martinvonz added a comment.
In https://phab.mercurial-scm.org/D6183#91060, @indygreg wrote:
> I support experimenting with putting copy metadata in the changelog. And
the patches before this one did a lot of work to allow copy metadata to be read
from alternate sources, which is great, s
indygreg added a comment.
An idea to consider (which may have been proposed already) is to write a *no
copy metadata* entry into extras when writing copy metadata to the changelog.
If we did things this way, a new client could know definitively that no copy
metadata is available and to not f
indygreg added a comment.
I support experimenting with putting copy metadata in the changelog. And the
patches before this one did a lot of work to allow copy metadata to be read
from alternate sources, which is great, since it can allow flexibility in the
future (think copy caches, copy mod
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG0fdf45cb3dc6: copies: add config option for writing copy
metadata to file and/or changset (authored by martinvonz, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mer
martinvonz updated this revision to Diff 14766.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6183?vs=14738&id=14766
REVISION DETAIL
https://phab.mercurial-scm.org/D6183
AFFECTED FILES
mercurial/changelog.py
mercurial/configitems.py
mercurial/loc
martinvonz added a comment.
In https://phab.mercurial-scm.org/D6183#90738, @yuja wrote:
> > > > > extras field. Almost all extras data are texts, and IIRC we
regret that
> > > > > transplant sources are stored in binary form.
> > > >
> > > > Why not? I picked \0 a
yuja added a comment.
> > > > extras field. Almost all extras data are texts, and IIRC we
regret that
> > > > transplant sources are stored in binary form.
> > >
> > > Why not? I picked \0 and \n because they won't appear in filenames,
so it's convenient in that way.
> > > > extras field. Almost all extras data are texts, and IIRC we regret
> that
> > > > transplant sources are stored in binary form.
> > >
> > > Why not? I picked \0 and \n because they won't appear in filenames,
> so it's convenient in that way.
> >
> > I don't remember
martinvonz updated this revision to Diff 14738.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6183?vs=14734&id=14738
REVISION DETAIL
https://phab.mercurial-scm.org/D6183
AFFECTED FILES
mercurial/changelog.py
mercurial/configitems.py
mercurial/loc
martinvonz added a comment.
In https://phab.mercurial-scm.org/D6183#90722, @yuja wrote:
> > > It might be nitpicky, but I think it's better to not embed `\0` into
the
> > > extras field. Almost all extras data are texts, and IIRC we regret
that
> > > transplant sources are st
yuja added a comment.
> > It might be nitpicky, but I think it's better to not embed `\0` into the
> > extras field. Almost all extras data are texts, and IIRC we regret that
> > transplant sources are stored in binary form.
>
> Why not? I picked \0 and \n because they won'
> > It might be nitpicky, but I think it's better to not embed `\0` into the
> > extras field. Almost all extras data are texts, and IIRC we regret that
> > transplant sources are stored in binary form.
>
> Why not? I picked \0 and \n because they won't appear in filenames, so it's
>
martinvonz updated this revision to Diff 14734.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6183?vs=14663&id=14734
REVISION DETAIL
https://phab.mercurial-scm.org/D6183
AFFECTED FILES
mercurial/changelog.py
mercurial/configitems.py
mercurial/loc
martinvonz added a comment.
In https://phab.mercurial-scm.org/D6183#90698, @yuja wrote:
> > +def encodecopies(copies):
> > +items = [
> > +'%s\0%s' % (_string_escape(k), _string_escape(copies[k]))
> > +for k in sorted(copies)
> > +]
> > +return "\
yuja added a comment.
> +def encodecopies(copies):
> +items = [
> +'%s\0%s' % (_string_escape(k), _string_escape(copies[k]))
> +for k in sorted(copies)
> +]
> +return "\n".join(items)
It might be nitpicky, but I think it's better to not embed `\0`
> +def encodecopies(copies):
> +items = [
> +'%s\0%s' % (_string_escape(k), _string_escape(copies[k]))
> +for k in sorted(copies)
> +]
> +return "\n".join(items)
It might be nitpicky, but I think it's better to not embed `\0` into the
extras field. Almost all extras dat
martinvonz added a comment.
In https://phab.mercurial-scm.org/D6183#90573, @gracinet wrote:
> We had half an hour of direct chat about this yesterday, with @martinvonz
and @marmoute. Here's a summary
>
> - The architecture of the proposed change makes the storage and conveying
of the
gracinet added a comment.
We had half an hour of direct chat about this yesterday, with @martinvonz and
@marmoute. Here's a summary
- The architecture of the proposed change makes the storage and conveying of
the information orthogonal to its usage. Therefore, it can be built upon to
in
pulkit added a comment.
In https://phab.mercurial-scm.org/D6183#90498, @martinvonz wrote:
> In https://phab.mercurial-scm.org/D6183#90486, @pulkit wrote:
>
> > In https://phab.mercurial-scm.org/D6183#90481, @martinvonz wrote:
> >
> > > In https://phab.mercurial-scm.org/D6183#90327,
martinvonz added a comment.
In https://phab.mercurial-scm.org/D6183#90486, @pulkit wrote:
> In https://phab.mercurial-scm.org/D6183#90481, @martinvonz wrote:
>
> > In https://phab.mercurial-scm.org/D6183#90327, @martinvonz wrote:
> >
> > > In https://phab.mercurial-scm.org/D6183#90
pulkit added a comment.
In https://phab.mercurial-scm.org/D6183#90481, @martinvonz wrote:
> In https://phab.mercurial-scm.org/D6183#90327, @martinvonz wrote:
>
> > In https://phab.mercurial-scm.org/D6183#90300, @marmoute wrote:
> >
> > > I am quite enthousiastic for a non-filelog b
martinvonz added a comment.
In https://phab.mercurial-scm.org/D6183#90470, @gracinet wrote:
> Hi Martin,
>
> Thanks for taking on copy tracing, it's been on our mind for a while, too.
>
> Some of our users would be very interested in the expected speedups of the
copy tracing syste
martinvonz added a comment.
In https://phab.mercurial-scm.org/D6183#90327, @martinvonz wrote:
> In https://phab.mercurial-scm.org/D6183#90300, @marmoute wrote:
>
> > I am quite enthousiastic for a non-filelog based copy tracing using
commit level information. However, I am very unenth
gracinet added a comment.
Hi Martin,
Thanks for taking on copy tracing, it's been on our mind for a while, too.
Some of our users would be very interested in the expected speedups of the
copy tracing system, however the impact of putting that data in the changeset
itself would not b
martinvonz added a comment.
In https://phab.mercurial-scm.org/D6183#90300, @marmoute wrote:
> I am quite enthousiastic for a non-filelog based copy tracing using commit
level information. However, I am very unenthousiastic at the idea of storing
more copy data in the changeset itself. Th
marmoute added a comment.
I am quite enthousiastic for a non-filelog based copy tracing using commit
level information. However, I am very unenthousiastic at the idea of storing
more copy data in the changeset itself. The "files" field in the changelog is
already quite problematic (about 95%
martinvonz updated this revision to Diff 14663.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6183?vs=14657&id=14663
REVISION DETAIL
https://phab.mercurial-scm.org/D6183
AFFECTED FILES
mercurial/changelog.py
mercurial/configitems.py
mercurial/loc
martinvonz updated this revision to Diff 14657.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6183?vs=14624&id=14657
REVISION DETAIL
https://phab.mercurial-scm.org/D6183
AFFECTED FILES
mercurial/changelog.py
mercurial/configitems.py
mercurial/loc
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This introduces a config option that lets you choose to write copy
metadata to the changeset extras instead of to filelog. There's also
an option to write it
30 matches
Mail list logo
