mharbison72 added a comment.
In https://phab.mercurial-scm.org/D6196#90521, @yuja wrote:
> > 4 org.python.python 0x0001000eb761
va_build_value + 737
> > 5 org.python.python 0x0001000eb837
_Py_BuildValue_SizeT + 167
>
> Maybe we
yuja added a comment.
> 4 org.python.python 0x0001000eb761
va_build_value + 737
> 5 org.python.python 0x0001000eb837
_Py_BuildValue_SizeT + 167
Maybe we shouldn't trust the Python doc too much, which says 's#' of
> 4 org.python.python 0x0001000eb761
> va_build_value + 737
> 5 org.python.python 0x0001000eb837
> _Py_BuildValue_SizeT + 167
Maybe we shouldn't trust the Python doc too much, which says 's#' of
Py_BuildValue() takes an int.
mharbison72 added a comment.
I don't have time to look into this, but this makes the mac builds very
unhappy. (The parent runs fine.) Somehow the bot is still running, but
recording various segfaults. When I tried to investigate, the build process
fails because `python hg version` is
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGb01bbb8ff1f2: cext: make revlog.c PY_SSIZE_T_CLEAN
(authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6196?vs=14652=14669
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Without this, Python 3.8 emits a deprecation warning, as using
int for # values is deprecated. Many existing modules use
PY_SSIZE_T_CLEAN, so this shouldn't be
