pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This patch adds functions to validate closed nodes, validate nodes for a
certain
branch and for all the branches. These functions will be used in upcoming
patche
yuja added a comment.
Queued, thanks.
> +def _verifybranch(self, branch):
> +""" verify head nodes for the given branch. If branch is None,
verify
> +for all the branches """
"If branch is None, ..." appears wrong.
> +if branch not in self._entr
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG2f8147521e59: branchcache: add functions to validate
changelog nodes (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6207?vs=1
pulkit added a comment.
In https://phab.mercurial-scm.org/D6207#90778, @yuja wrote:
> Queued, thanks.
>
> > +def _verifybranch(self, branch):
> > +""" verify head nodes for the given branch. If branch is None,
verify
> > +for all the branches """
>
> "If
yuja added a comment.
> The motivation behind iteritems() change
(https://phab.mercurial-scm.org/D6236) is optimizing
https://www.mercurial-scm.org/repo/hg-committed/file/70b71421fd33/mercurial/commands.py#l1128.
Okay, got that, thanks.
> Maybe we can iterate over verified nodes
Queued, thanks.
> +def _verifybranch(self, branch):
> +""" verify head nodes for the given branch. If branch is None, verify
> +for all the branches """
"If branch is None, ..." appears wrong.
> +if branch not in self._entries or branch in self._verifiedbranches:
> +
> The motivation behind iteritems() change
> (https://phab.mercurial-scm.org/D6236) is optimizing
> https://www.mercurial-scm.org/repo/hg-committed/file/70b71421fd33/mercurial/commands.py#l1128.
Okay, got that, thanks.
> Maybe we can iterate over verified nodes first, and then iterate over
